-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManagedZoneInfo class added #575
Conversation
import java.util.Objects; | ||
|
||
/** | ||
* This class is a container for the managed zone metainformation. Managed zone is a resource that |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I finished processing the comments. The PR is ready for another review pass. |
} | ||
|
||
@Test | ||
public void testValidCreationTime() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks good! Just few more nits |
I finished the processing the feedback. This is ready for another pass. |
c09799e
to
dacea19
Compare
🤖 I have created a release *beep* *boop* --- ## [0.6.6](https://github.com/googleapis/java-securitycenter-settings/compare/v0.6.5...v0.6.6) (2022-10-05) ### Dependencies * Update dependency certifi to v2022.9.24 ([#566](https://github.com/googleapis/java-securitycenter-settings/issues/566)) ([f9c5954](https://github.com/googleapis/java-securitycenter-settings/commit/f9c59549ce924c3d11e3e97c435981ea2e45fdf0)) * Update dependency charset-normalizer to v2.1.1 ([#570](https://github.com/googleapis/java-securitycenter-settings/issues/570)) ([1a67981](https://github.com/googleapis/java-securitycenter-settings/commit/1a67981fbc19320fbca4abc35b4e6da4a3561b0f)) * Update dependency click to v8.1.3 ([#571](https://github.com/googleapis/java-securitycenter-settings/issues/571)) ([a8f784e](https://github.com/googleapis/java-securitycenter-settings/commit/a8f784efe83cb56d8ea68a07c3aae2c6a3c7d003)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#577](https://github.com/googleapis/java-securitycenter-settings/issues/577)) ([1f98eed](https://github.com/googleapis/java-securitycenter-settings/commit/1f98eed175c141b30b06a97e5a7834583b1b9f40)) * Update dependency gcp-releasetool to v1.8.8 ([#567](https://github.com/googleapis/java-securitycenter-settings/issues/567)) ([663ab9f](https://github.com/googleapis/java-securitycenter-settings/commit/663ab9f0f3ce00f34b5b8fcf0c21f696b0fdf455)) * Update dependency google-api-core to v2.10.1 ([#572](https://github.com/googleapis/java-securitycenter-settings/issues/572)) ([8dcd58c](https://github.com/googleapis/java-securitycenter-settings/commit/8dcd58c2c65d7d64cbb1b4502f5b53eb7b11777c)) * Update dependency google-auth to v2.12.0 ([#573](https://github.com/googleapis/java-securitycenter-settings/issues/573)) ([26df30b](https://github.com/googleapis/java-securitycenter-settings/commit/26df30bf335aecb286d92195d6ec44c5f2d52f16)) * Update dependency google-cloud-core to v2.3.2 ([#568](https://github.com/googleapis/java-securitycenter-settings/issues/568)) ([dd01a84](https://github.com/googleapis/java-securitycenter-settings/commit/dd01a84cbf89b05330ce9f05c5a786c6f40ab03f)) * Update dependency google-cloud-storage to v2.5.0 ([#574](https://github.com/googleapis/java-securitycenter-settings/issues/574)) ([4b2b3f5](https://github.com/googleapis/java-securitycenter-settings/commit/4b2b3f5625c9be96c788ebcda38093d616beb805)) * Update dependency googleapis-common-protos to v1.56.4 ([#569](https://github.com/googleapis/java-securitycenter-settings/issues/569)) ([248ad71](https://github.com/googleapis/java-securitycenter-settings/commit/248ad71bfb348cdac2e8ea2091a311a1b97eedba)) * Update dependency jinja2 to v3.1.2 ([#575](https://github.com/googleapis/java-securitycenter-settings/issues/575)) ([098d82a](https://github.com/googleapis/java-securitycenter-settings/commit/098d82ab1cdbc575c075dcde35baecc1f6778a82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-retail/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
…2.0 (#575) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.5` -> `26.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.2.0/compatibility-slim/26.1.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.2.0/confidence-slim/26.1.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
No description provided.